It's now possible to delete a service that is not connected to a Load Balancer - #78
Open
coredumperror wants to merge 1 commit into
Open
It's now possible to delete a service that is not connected to a Load Balancer#78coredumperror wants to merge 1 commit into
coredumperror wants to merge 1 commit into
Conversation
… Balancer Previously, the `deploy service delete` command would crash with an IndexError if the user tried to delete a service that had already been disconnected from its load balancer. Now, the delete command will get past that, correctly report that there is no listener rule connected to the service's target group, and successfully delete the ECS service.
Collaborator
|
As usual, please write tests for this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
deploy service deletecommand would crash with an IndexError if the user tried to delete a service that had already been disconnected from its load balancer.Now, the delete command will get past that, correctly report that there is no listener rule connected to the service's target group, and successfully delete the ECS service.
I used this updated version successfully to delete several services that had already been disconnected from their respective load balancers, and as far as I can tell, it worked flawlessly.